From 59381bc5e7945d39e3f1688c202375df9707a499 Mon Sep 17 00:00:00 2001
From: bponders12-cell <bponders12@gmail.com>
Date: Tue, 1 Sep 2026 21:04:04 -0400
Subject: [PATCH] Test real v5 to v6 ride identity migration

---
 test/cloud_ride_identity_migration_test.dart | 61 ++++++++++++++++++++
 1 file changed, 61 insertions(+)

diff --git a/test/cloud_ride_identity_migration_test.dart b/test/cloud_ride_identity_migration_test.dart
index 269ad22..a6f1155 100644
--- a/test/cloud_ride_identity_migration_test.dart
+++ b/test/cloud_ride_identity_migration_test.dart
@@ -34,4 +34,65 @@ void main() {
 
     expect(second, first);
   });
+
+  test('real v5 rides migrate to their legacy MotorCloud identity', () async {
+    final connection = NativeDatabase.memory(setup: (rawDb) {
+      rawDb.execute('''
+        CREATE TABLE rides (
+          id INTEGER PRIMARY KEY AUTOINCREMENT,
+          start_time INTEGER NOT NULL,
+          end_time INTEGER,
+          distance_miles REAL NOT NULL DEFAULT 0.0,
+          top_speed_mph REAL NOT NULL DEFAULT 0.0,
+          max_lean_left REAL NOT NULL DEFAULT 0.0,
+          max_lean_right REAL NOT NULL DEFAULT 0.0,
+          max_accel_g REAL NOT NULL DEFAULT 0.0,
+          max_braking_g REAL NOT NULL DEFAULT 0.0,
+          best0to60_ms REAL,
+          best0to100_ms REAL,
+          distance REAL NOT NULL DEFAULT 0.0,
+          moving_time INTEGER NOT NULL DEFAULT 0,
+          stopped_time INTEGER NOT NULL DEFAULT 0,
+          average_speed REAL NOT NULL DEFAULT 0.0,
+          top_speed REAL NOT NULL DEFAULT 0.0,
+          elevation_gain REAL NOT NULL DEFAULT 0.0,
+          elevation_loss REAL NOT NULL DEFAULT 0.0,
+          motorcycle_id INTEGER,
+          motorcycle_year INTEGER,
+          motorcycle_make TEXT,
+          motorcycle_model TEXT,
+          motorcycle_variant TEXT
+        )
+      ''');
+      final start = DateTime.utc(2026, 8, 31, 21, 7, 5);
+      rawDb.execute('INSERT INTO rides (id, start_time) VALUES (?, ?)', [42, start.millisecondsSinceEpoch]);
+      rawDb.execute('PRAGMA user_version = 5');
+    });
+
+    final db = AppDatabase.forTesting(connection);
+    addTearDown(db.close);
+
+    final migrated = await db.getCloudRideId(42);
+    expect(migrated, 'ride_42_20260831_210705');
+
+    final rows = await db.customSelect('PRAGMA table_info(rides)').get();
+    expect(rows.any((row) => row.data['name'] == 'cloud_ride_id'), isTrue);
+
+    final indexes = await db.customSelect('PRAGMA index_list(rides)').get();
+    expect(indexes.any((row) => row.data['name'] == 'rides_cloud_ride_id_idx'), isTrue);
+  });
+
+  test('fresh database creation creates cloud identity column and unique index', () async {
+    final db = AppDatabase.forTesting(NativeDatabase.memory());
+    addTearDown(db.close);
+
+    final columns = await db.customSelect('PRAGMA table_info(rides)').get();
+    expect(columns.any((row) => row.data['name'] == 'cloud_ride_id'), isTrue);
+
+    final indexes = await db.customSelect('PRAGMA index_list(rides)').get();
+    expect(indexes.any((row) => row.data['name'] == 'rides_cloud_ride_id_idx'), isTrue);
+
+    final rideId = await db.startRide();
+    expect(await db.getCloudRideId(rideId), startsWith('ride_'));
+  });
 }